Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move binary detection to the parser #2923

Merged
merged 1 commit into from
Apr 24, 2017

Conversation

darrachequesne
Copy link
Member

Following socketio/socket.io-parser#66 and socketio/socket.io-client#1103.

Because the hasBinary check may be useless for some parser (like socket.io-msgpack-parser).

Also closes #2871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module crashes in Node if File or Blob global is defined
1 participant